Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paths.nim: Fix import for FreeBSD #238

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

lbartoletti
Copy link
Contributor

compiler doesn't seem to be standard.
At least, in FreeBSD, it's in ${LOCALBASE}/nim/lib/compiler where ${LOCALBASE} is /usr/local by default.

Add a when defined to import pathutils on FreeBSD.

`compiler` doesn't seem to be standard.
At least, in FreeBSD, it's in ${LOCALBASE}/nim/lib/compiler where ${LOCALBASE} is /usr/local by default.

Add a when defined to import `pathutils` on FreeBSD.
@pietroppeter
Copy link
Owner

Thanks for this, there is indeed a related issue #62 that I thought it was only arch specific but it turns out it might affect also freeBSD. I am not planning to test this but it looks a reasonable change and hopefully it helps on your side.

Looks ok for me, if @HugoGranstrom cannot come up with objections I would merge it.

@HugoGranstrom
Copy link
Collaborator

Yes looks good to me as well 👌

@lbartoletti
Copy link
Contributor Author

hopefully it helps on your side

Yes, it helps me and I'm starting to write my blog, and documentation with it :)

And... thanks to you and hugo for these tools!

@pietroppeter pietroppeter merged commit c7aa19f into pietroppeter:main Mar 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants